correction README.md #1140
Open
correction README.md #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting the dependency name from libsecret-1.0 to libsecret-1-dev, located in the "'Setting up & running the development version >>> Dependencies >>> You can get most of those from your distribution packages: >>> # On Debian/Ubuntu:' section."
|
Why? From what I can see, it adds nothing for us (unless mesen wants the pkg-config files?). In fact, we could remove (Also the PR title and commit message are super generic, something like "README: fix debian/ubuntu libsecret dependency" is way more descriptive, along with the why in the message body.) |
|
Definitely, if gir1.2-secret-1 is already going to drag libsecret-1 then we should get rid of that package in the list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting the dependency name from libsecret-1.0 to libsecret-1-dev, located in the "'Setting up & running the development version >>> Dependencies >>> You can get most of those from your distribution packages: >>> # On Debian/Ubuntu:' section."