Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version name #1129

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

SqAtx
Copy link
Contributor

@SqAtx SqAtx commented Jul 27, 2024

Update base version from 0.6.0 to 0.7-dev.

The idea is that when we're ready to release 0.7, we'll create a 0.7 branch. We'll then update the version to "0.7" on that branch, and "0.8-dev" on master.

Append the short commit hash in development mode (as before)

Append the date in flatpak mode, to help keep track of versions when using the weekly flatpak. Tested the flatpak by running the GHA workflow on my fork.

@SqAtx
Copy link
Contributor Author

SqAtx commented Jul 27, 2024

Interestingly, this didn't fix what I originally set out to fix:
image
It still says 0.6 in the list of flatpaks.

But the About dialog is correct:
image
The dev version, for comparison:
image

@diegogangl
Copy link
Contributor

The version for flatpak comes from the appdata.xml file: https://github.com/getting-things-gnome/gtg/blob/master/data/org.gnome.GTG.appdata.xml.in.in

I guess we could add a 0.7-dev version while we are working on a new release

@diegogangl diegogangl added the packaging Flatpak packages (anything else = NOPE.png) label Jul 29, 2024
@SqAtx
Copy link
Contributor Author

SqAtx commented Jul 29, 2024

Oh cool, I'll have a look at that file!

@SqAtx
Copy link
Contributor Author

SqAtx commented Aug 25, 2024

Hm it doesn't seem to be quite as simple as that. I tried adding <release version="0.7-dev" type="snapshot"></release> or <release version="0.7-dev" type="development"></release> at the top of the list of releases (as per https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Releases.html).

But it always shows 0.6 when inside flatpak list.

There may be a place to tell flatpak that this is a dev or snapshot version - I'll experiment.

@SqAtx
Copy link
Contributor Author

SqAtx commented Aug 25, 2024

Ah OK, I tried building the flatpak locally and I got "F: Ignoring release element without timestamp or date", which would explain it. And indeed, adding <release version="0.7-dev"/> (stable is the default) also results in flatpak list showing 0.6.

But there must be more to it. To be sure, I added

        <release version="0.7-dev" date="2022-03-05" type="development"/>
        <release version="0.7-snap" date="2022-03-04" type="snapshot"/>
        <release version="0.7-stable" date="2022-03-03" type="stable"/>

to the XML. Building the flatpak locally with sudo flatpak-builder --force-clean --install-deps-from=flathub --repo=repo --install builddir build-aux/org.gnome.GTG.Devel.json results in the version being 0.7-dev, as expected.

But pushing to a fork, triggering the workflow, downloading and installing the flatpak, still shows 0.6. I don't understand where it gets that 0.6 from

I updated the PR with something that works locally, but I'll keep digging to find out what's wrong with the weekly flatpak.

Update base version from 0.6.0 to 0.7-dev.

The idea is that when we're ready to release 0.7, we'll create a 0.7
branch. We'll then update the version to "0.7" on that branch, and
"0.8-dev" on master.

Append the short commit hash in development mode (as before)

Append the date when making a snapshot using flatpak, to help keep track
of versions when using the weekly flatpak. Tested the flatpak by running
the GHA workflow on my fork.
@SqAtx
Copy link
Contributor Author

SqAtx commented Sep 2, 2024

OK it works now
image
I think something was wrong with my test setup last time :)

I also renamed the flatpak meson profile to flatpak_snapshot. I think it makes more sense.

@diegogangl
Copy link
Contributor

LGTM! Thanks, and yeah dev snapshot looks better

@diegogangl diegogangl merged commit a34e8db into getting-things-gnome:master Sep 2, 2024
1 check passed
@SqAtx SqAtx deleted the version_name branch September 7, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Flatpak packages (anything else = NOPE.png)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants