Create a dummy button in the sidebar #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An invisible button catches the focus instead of the "All Tasks" row. Thanks to this button, unintended view resets can be avoided when a focused widget is removed. This fixes GitHub issue getting-things-gnome#1017
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
LGTM, thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1017 and the following points of #1018:
Based on a forum discussion, if the currently focused widget is removed, Gtk.Window selects the first suitable children. This is the "All Tasks" row in our case, thus causing a view reset. Other cases can also reproduce the anomaly: reparenting a tag, deleting a task, etc.
Now, an invisible button catches the focus instead of the "All Tasks" row. Thanks to this button, unintended view resets can be avoided when the focused widget is removed.
Theoretically, we could define a focus grab for each of these special cases. However, we would risk that we miss one and the bug comes back. Moreover, this change doesn't affect the complexity of other code parts.