Update models for subtasks upon changes #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tid_to_subtask_model field keeps track of the ListStores created for subtasks. The _remove_from_parent_model and _append_to_model helper functions update these models when a change happens. This functionality helps to keep the UI up-to-date. This fixes one of the problems listed in GitHub issue getting-things-gnome#1018
|
Great job! Now we can get rid of that awful collapse/expand hack to update the ui :) |
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the problems listed in GitHub issue #1018:
The main changes are as follows:
tid_to_subtask_modelfield keeps track of theListStores created for subtasks._remove_from_parent_modeland_append_to_modelhelper functions update these models when a change happens.