-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SymCache Transformers (NATIVE-463) #496
Conversation
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 68.62% 68.85% +0.22%
==========================================
Files 83 84 +1
Lines 17365 17472 +107
==========================================
+ Hits 11917 12030 +113
+ Misses 5448 5442 -6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks largely fine. I wonder if the transformers also need to be able to change the symcache header so that e.g. you can distinguish one that's been transformed by a BCSymbolMap transformer and one that is not.
These allow transforming the function and source location records that will be written into SymCaches.
732694a
to
3e2cd11
Compare
fn insert_string(&mut self, s: &str) -> u32 { | ||
fn insert_string( | ||
string_bytes: &mut Vec<u8>, | ||
strings: &mut HashMap<String, u32>, | ||
s: &str, | ||
) -> u32 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is some sort of borrow checker dance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, since I can’t borrow all of self
:-(
These allow transforming the function and source location records that
will be written into SymCaches.
fixes #422