-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[debuginfo] No error in functions iterator on name errors #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
debuginfo/src/dwarf.rs
Outdated
|
||
let function = Function { | ||
address: function_address, | ||
size: function_size, | ||
name: Name::with_language(name.unwrap_or_default(), self.language), | ||
name: Name::with_language( | ||
name.unwrap_or_else(|| Cow::from("<name omitted>")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you leave this an empty string and coerce in the caller? We rely on this being empty in Sentry since we show our own placeholders which have semantic meaning.
debuginfo/src/dwarf.rs
Outdated
let file = self | ||
.resolve_file(row.file_index) | ||
.ok() | ||
.flatten() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since both usages now only require an option, can you change the function signature to Option<FileInfo>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It aims to fix: #195