Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(common): Revert to string-based CodeId #139

Merged
merged 1 commit into from
May 7, 2019
Merged

ref(common): Revert to string-based CodeId #139

merged 1 commit into from
May 7, 2019

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented May 7, 2019 •
edited
Loading

debugid 0.5.2 is released already.

@jan-auer jan-auer requested a review from untitaker May 7, 2019 15:52
@jan-auer jan-auer self-assigned this May 7, 2019
untitaker
untitaker approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I would like armin to take a look

@jan-auer
Copy link
Member Author

jan-auer commented May 7, 2019

Let's take the easy route now by reverting to the previous debugid build and discuss this in more detail afterwards.

@jan-auer jan-auer merged commit 37b465f into master May 7, 2019
@jan-auer jan-auer deleted the ref/revert-code-id branch May 7, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @untitaker