Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(mediators): Convert the other external request mediators #78662

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Christinarlong
Copy link
Contributor

[x] SelectRequester
[x] IssueLinkRequester
[x] tests
[x] typing

loggers

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
21723 2 21721 214
View the top 2 failed tests by shortest run time
tests.sentry.sentry_apps.test_sentry_app_component_preparer.TestPreparerIssueLink test_prepares_components_requiring_requests
Stack Traces | 4.37s run time
#x1B[1m#x1B[.../sentry/testutils/silo.py#x1B[0m:231: in _callTestMethod
    return TestCase._callTestMethod(obj, method)  # type: ignore[attr-defined]
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/unittest/mock.py#x1B[0m:1390: in patched
    with self.decoration_helper(patched,
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/contextlib.py#x1B[0m:137: in __enter__
    return next(self.gen)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/unittest/mock.py#x1B[0m:1372: in decoration_helper
    arg = exit_stack.enter_context(patching)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/contextlib.py#x1B[0m:526: in enter_context
    result = _enter(cm)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/unittest/mock.py#x1B[0m:1445: in __enter__
    self.target = self.getter()
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/pkgutil.py#x1B[0m:528: in resolve_name
    result = getattr(result, p)
#x1B[1m#x1B[31mE   AttributeError: module 'sentry.sentry_apps.external_requests' has no attribute 'SelectRequester'. Did you mean: 'select_requester'?#x1B[0m
tests.sentry.sentry_apps.test_sentry_app_component_preparer.TestPreparerAlertRuleAction test_prepares_components_requiring_requests
Stack Traces | 7.21s run time
#x1B[1m#x1B[.../sentry/testutils/silo.py#x1B[0m:231: in _callTestMethod
    return TestCase._callTestMethod(obj, method)  # type: ignore[attr-defined]
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/unittest/mock.py#x1B[0m:1390: in patched
    with self.decoration_helper(patched,
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/contextlib.py#x1B[0m:137: in __enter__
    return next(self.gen)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/unittest/mock.py#x1B[0m:1372: in decoration_helper
    arg = exit_stack.enter_context(patching)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/contextlib.py#x1B[0m:526: in enter_context
    result = _enter(cm)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/unittest/mock.py#x1B[0m:1445: in __enter__
    self.target = self.getter()
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6................../x64/lib/python3.12/pkgutil.py#x1B[0m:528: in resolve_name
    result = getattr(result, p)
#x1B[1m#x1B[31mE   AttributeError: module 'sentry.sentry_apps.external_requests' has no attribute 'SelectRequester'. Did you mean: 'select_requester'?#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant