Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metrics): remove create alert and create widget actions #78596

Closed
wants to merge 1 commit into from
Closed

chore(metrics): remove create alert and create widget actions #78596

wants to merge 1 commit into from

Conversation

obostjancic
Copy link
Member

@obostjancic obostjancic added the Do Not Merge Don't merge label Oct 4, 2024
@obostjancic obostjancic self-assigned this Oct 4, 2024
@obostjancic obostjancic requested review from a team as code owners October 4, 2024 07:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 4, 2024
@obostjancic obostjancic linked an issue Oct 4, 2024 that may be closed by this pull request
DDM Beta end #77547
Open
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
7919 2 7917 0
View the top 2 failed tests by shortest run time 
Dashboards > Detail custom dashboards shows add widget option without dataset selector flag Dashboards > Detail custom dashboards shows add widget option without dataset selector flag
Stack Traces | 0.477s run time 
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 0

  Array [
    "Errors and Transactions",
    "Issues",
    "Releases",
-   "Metrics",
  ]
    at Object.<anonymous> (.../views/dashboards/detail.spec.tsx:525:51)

Dashboards > Detail custom dashboards shows add widget option with dataset selector flag Dashboards > Detail custom dashboards shows add widget option with dataset selector flag
Stack Traces | 0.604s run time 
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 0

  Array [
    "Errors",
    "Transactions",
    "Issues",
    "Releases",
-   "Metrics",
  ]
    at Object.<anonymous> (.../views/dashboards/detail.spec.tsx:499:51)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

ArthurKnaus
ArthurKnaus approved these changes Oct 4, 2024
View reviewed changes
static/app/views/alerts/wizard/options.tsx
Comment on lines -154 to +155
categoryHeading: hasCustomMetrics(org) ? t('Metrics') : t('Custom'),
options: [hasCustomMetrics(org) ? 'custom_metrics' : 'custom_transactions'],
categoryHeading: t('Custom'),
options: ['custom_transactions'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove
...(hasCustomMetrics(org) ? (['custom_transactions'] satisfies AlertType[]) : []),
It is a few lines above.

static/app/views/metrics/metricQueryContextMenu.tsx
return undefined;
}
return function () {
openCreateAlertModal({metricsQuery: metricsQuery, organization});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete the create alert modal.
It is specific to metrics.

@obostjancic obostjancic closed this Oct 4, 2024
@obostjancic obostjancic mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurKnaus ArthurKnaus ArthurKnaus approved these changes

Assignees

@obostjancic obostjancic

Labels
Do Not Merge Don't merge Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DDM Beta end
2 participants
@obostjancic @ArthurKnaus