-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(issue-views): Load in default view by default if issue views enabled) #78278
Merged
MichaelSun48
merged 1 commit into
master
from
msun/issueViews/stopPreviousQueryFromFlashing
Sep 30, 2024
Merged
fix(issue-views): Load in default view by default if issue views enabled) #78278
MichaelSun48
merged 1 commit into
master
from
msun/issueViews/stopPreviousQueryFromFlashing
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Sep 27, 2024
Bundle ReportChanges will increase total bundle size by 85 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
MichaelSun48
force-pushed
the
msun/issueViews/stopPreviousQueryFromFlashing
branch
from
September 27, 2024 23:02
7856c8e
to
08ef0c1
Compare
malwilley
approved these changes
Sep 30, 2024
MichaelSun48
deleted the
msun/issueViews/stopPreviousQueryFromFlashing
branch
September 30, 2024 17:22
MichaelSun48
added
the
Trigger: Revert
add to a merged PR to revert it (skips CI)
label
Sep 30, 2024
PR reverted: f2034a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Scope: Frontend
Automatically applied to PRs that change frontend components
Trigger: Revert
add to a merged PR to revert it (skips CI)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where you'd see the default query flash in the search bar breifly when loading
/issues/
, or when clicking the issues tab. Does this by hijacking the saved searches HOC, and returning the default issue view instead of the default search view if the organization has the feature enabled.This might also help the views load in faster, since the fetch request occurs earlier in the rendering cycle.
I could not figure out how to stop the page filters from flashing some values, but I will continue to look into this:
Before:
Screen.Recording.2024-09-27.at.12.08.09.PM.mov
After
Screen.Recording.2024-09-27.at.12.09.32.PM.mov
notice how in the After video, the search query remains static even after clicking the issues tab