ref(scm): search endpoint abstraction round 2 #77079
Conversation
github-actions
bot
added
the
Scope: Backend
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| response = installation.search_issues(query=full_query, project_id=repo, iids=iids) | ||
| except ApiError as e: | ||
| return Response({"detail": str(e)}, status=400) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
| try: | ||
| response = installation.search_projects(query) | ||
| except ApiError as e: | ||
| return Response({"detail": str(e)}, status=400) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77079 +/- ##
===========================================
+ Coverage 57.37% 78.14% +20.76%
===========================================
Files 6927 6939 +12
Lines 307427 307970 +543
Branches 50326 50410 +84
===========================================
+ Hits 176400 240675 +64275
+ Misses 126188 60875 -65313
- Partials 4839 6420 +1581 |
| if not query: | ||
| return Response([]) | ||
|
|
||
| resp = installation.search_issues(query=query) |
There was a problem hiding this comment.
vsts doesn't query issues with repository, needed to account for that. there isn't a test for VSTS, may need to add that?
There was a problem hiding this comment.
Yeah makes sense. Please at least add barebone tests.
cathteng
force-pushed
the
cathy/scm/search-endpoint-abstraction
branch
from
58b6f5c
to
dc07360
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Fixed version of #76627