feat: Update Loader script to be v8 compatible #73831
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
| @@ -1,5 +1,5 @@ | |||
| declare const __LOADER__PUBLIC_KEY__: any; | |||
| declare const __LOADER_SDK_URL__: any; | |||
| declare const __LOADER__SDK_URL__: any; | |||
There was a problem hiding this comment.
This is not directly related but noticed that this was inconsistent before!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73831 +/- ##
==========================================
+ Coverage 78.08% 78.11% +0.03%
==========================================
Files 6659 6659
Lines 297923 297920 -3
Branches 51259 51256 -3
==========================================
+ Hits 232639 232731 +92
+ Misses 58986 58904 -82
+ Partials 6298 6285 -13 |
Bundle ReportChanges will increase total bundle size by 235 bytes ⬆️
|
This updates the Loader Script to ensure we also check for an already installed instance of the SDK under v8, where the global carrier `window.__SENTRY__` has a different shape. Part of getsentry/sentry-javascript#12187 * Tests for v8: getsentry/sentry-javascript#12764 * Tests for v7: getsentry/sentry-javascript#12765
This updates the Loader Script to ensure we also check for an already installed instance of the SDK under v8, where the global carrier
window.__SENTRY__has a different shape.Part of getsentry/sentry-javascript#12187