Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample_rate applying to non error events #2203

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

sl0thentr0py
Copy link
Member

fixes #2202

#skip-changelog

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #2203 (df45cce) into master (9895426) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2203   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         100      100           
  Lines        3734     3734           
=======================================
  Hits         3635     3635           
  Misses         99       99           
Components Coverage Δ
sentry-ruby 98.02% <100.00%> (-0.04%) ⬇️
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 94.53% <ø> (ø)
sentry-resque 93.65% <ø> (+1.58%) ⬆️
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 502547e into master Dec 18, 2023
98 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-sample-rate-check-in branch December 18, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron CheckIn events are affected by sample_rate
2 participants