Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate capture_exception_frame_locals in favor of include_local_variables #1993

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Feb 4, 2023

Closes #1986

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 98.57% // Head: 98.57% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4131b43) compared to base (75f289d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   98.57%   98.57%   -0.01%     
==========================================
  Files         157      157              
  Lines       10056    10073      +17     
==========================================
+ Hits         9913     9929      +16     
- Misses        143      144       +1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/test_helper.rb 100.00% <ø> (ø)
sentry-ruby/lib/sentry-ruby.rb 96.47% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 98.53% <100.00%> (+0.02%) ⬆️
sentry-ruby/spec/sentry/configuration_spec.rb 100.00% <100.00%> (ø)
...y-ruby/spec/sentry/rack/capture_exceptions_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry_spec.rb 99.80% <100.00%> (ø)
sentry-resque/lib/sentry/resque.rb 97.22% <0.00%> (-2.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012 st0012 changed the title Deprecate capture_exception_frame_locals with include_local_variables Deprecate capture_exception_frame_locals in favor of include_local_variables Feb 4, 2023
@st0012
Copy link
Collaborator Author

st0012 commented Feb 4, 2023

@sl0thentr0py The coverage drop happens in sentry-resque, which is completely unrelated to the changes.
I think there's some mis-setup from me on multi-folder reporting. But I don't feel like fine-tuning it atm.

@sl0thentr0py
Copy link
Member

yea this codecov thing is a bit annoying atm :/

I'll try to clean it up next week.

@sl0thentr0py sl0thentr0py merged commit 8b7267e into master Feb 6, 2023
@sl0thentr0py sl0thentr0py deleted the fix-#1986 branch February 6, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate capture_exception_frame_locals in favour of includeLocalVariables
2 participants