Return value from 'perform_action' when initialized #1966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
ActionCable::Channel::Base#perform_action
in our Action Cable testing and would like to use its return value as part of those tests. At the minute, when the SDK is not initialized then this works OK, as the return value ofblock.call
is immediately returned:sentry-ruby/sentry-rails/lib/sentry/rails/action_cable.rb
Line 9 in dce8ef0
However, if we initialize the SDK, then the return value is swallowed. This change ensures that the result of
block.call
is returned in all situations, apart from when an error is raised in the block.