Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add spotlight option #4023

Merged
merged 5 commits into from
Aug 14, 2024
Merged

feat: Add spotlight option #4023

merged 5 commits into from
Aug 14, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • New feature

📜 Description

Alight witht the JS SDK which uses spotlight: true | string.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fb00f28

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Aug 13, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.84 ms 1234.25 ms 1.41 ms
Size 2.36 MiB 3.07 MiB 725.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
f06c879+dirty 1252.64 ms 1259.66 ms 7.02 ms
5a22220+dirty 1209.49 ms 1220.94 ms 11.45 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
f06c879+dirty 2.36 MiB 2.88 MiB 530.42 KiB
5a22220+dirty 2.36 MiB 2.92 MiB 570.21 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) August 14, 2024 09:02
@krystofwoldrich krystofwoldrich merged commit 7b891b1 into main Aug 14, 2024
53 of 56 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/add-spotlight-option branch August 14, 2024 09:04
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 469.96 ms 490.27 ms 20.31 ms
Size 17.73 MiB 20.06 MiB 2.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
27ef4ee 317.40 ms 321.70 ms 4.30 ms
6e8584e 447.10 ms 474.71 ms 27.61 ms
148f924 492.65 ms 500.28 ms 7.63 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
575f9da 415.26 ms 422.98 ms 7.72 ms
1c65324 426.37 ms 460.36 ms 33.99 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms

App size

Revision Plain With Sentry Diff
27ef4ee 17.73 MiB 19.82 MiB 2.08 MiB
6e8584e 17.73 MiB 19.86 MiB 2.12 MiB
148f924 17.73 MiB 19.94 MiB 2.21 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
575f9da 17.73 MiB 19.83 MiB 2.10 MiB
1c65324 17.73 MiB 19.95 MiB 2.21 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants