Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.14.2 #3340

Merged
merged 1 commit into from
Oct 30, 2023
Merged

chore(deps): update Cocoa SDK to v8.14.2 #3340

merged 1 commit into from
Oct 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 13, 2023 •
edited
Loading

Bumps scripts/update-cocoa.sh from 8.13.0 to 8.14.2.

Auto-generated by a dependency updater.

Changelog

8.14.2

Features

  • Enrich error events with any underlying NSErrors reported by Cocoa APIs (#3230)

Features

  • Improve OOM detection by ignoring system reboot (#3352)

Fixes

  • Reporting app hangs from background (#3298)
  • Missing mechanism.handled is not considered crash (#3353)

8.14.1

Fixes

  • SPM build failure involving "unsafe settings" (#3348)

8.14.0

Features

  • Sentry can now be used without linking UIKit; this is helpful for using the SDK in certain app extension contexts (#3175)
    Warning: this breaks some SPM integrations. Use 8.14.1 if you integrate using SPM.

  • GA of MetricKit integration (#3340)

Once enabled, this feature subscribes to MetricKit's MXDiagnosticPayload data, converts it to events, and sends it to Sentry.
The MetricKit integration subscribes to MXHangDiagnostic,
MXDiskWriteExceptionDiagnostic,
and MXCPUExceptionDiagnostic.

8.13.1

Fixes

  • Always start SDK on the main thread (#3291)
  • App hang with race condition for tick counter (#3290)
  • Remove "duplicate library" warning (#3312)
  • Fix multiple issues in Reachability (#3338)
  • Remove unnecessary build settings (#3325)
  • Crash in SentryTracer when cancelling timer (#3333)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 13, 2023
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 13, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 364.10 ms 392.98 ms 28.88 ms
Size 17.73 MiB 19.86 MiB 2.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
9c48b2c 349.24 ms 385.96 ms 36.72 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
0677344 327.74 ms 337.14 ms 9.40 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
abb7058 370.27 ms 389.58 ms 19.31 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
9c48b2c 17.73 MiB 19.80 MiB 2.07 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
87d728a 426.02 ms 432.73 ms 6.71 ms
357b71f 401.70 ms 415.62 ms 13.92 ms
955f10d 351.88 ms 364.50 ms 12.62 ms
8da52c9+dirty 385.21 ms 422.36 ms 37.15 ms
a4302f1 398.60 ms 428.38 ms 29.78 ms
94f9b87+dirty 319.37 ms 330.10 ms 10.73 ms
1573004 381.49 ms 408.94 ms 27.45 ms
8ba8074 326.52 ms 339.04 ms 12.52 ms
1dc092f 420.22 ms 434.90 ms 14.68 ms
c1659ab 333.94 ms 356.55 ms 22.61 ms

App size

Revision Plain With Sentry Diff
87d728a 17.73 MiB 19.86 MiB 2.12 MiB
357b71f 17.73 MiB 19.86 MiB 2.12 MiB
955f10d 17.73 MiB 19.80 MiB 2.07 MiB
8da52c9+dirty 17.73 MiB 20.04 MiB 2.31 MiB
a4302f1 17.73 MiB 19.85 MiB 2.12 MiB
94f9b87+dirty 17.73 MiB 19.75 MiB 2.01 MiB
1573004 17.73 MiB 19.83 MiB 2.10 MiB
8ba8074 17.73 MiB 19.81 MiB 2.08 MiB
1dc092f 17.73 MiB 19.84 MiB 2.10 MiB
c1659ab 17.73 MiB 19.83 MiB 2.09 MiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 13, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1264.62 ms 1267.54 ms 2.92 ms
Size 2.92 MiB 3.44 MiB 538.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
dadc233+dirty 1266.52 ms 1282.55 ms 16.03 ms
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
ad6c299+dirty 1248.50 ms 1248.88 ms 0.38 ms

App size

Revision Plain With Sentry Diff
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
dadc233+dirty 2.92 MiB 3.40 MiB 492.53 KiB
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
ad6c299+dirty 2.92 MiB 3.40 MiB 494.12 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
a4302f1+dirty 1228.08 ms 1230.64 ms 2.56 ms
94f9b87+dirty 1269.94 ms 1273.11 ms 3.17 ms
8ba8074+dirty 1284.04 ms 1309.42 ms 25.38 ms
1dc092f+dirty 1235.00 ms 1236.54 ms 1.54 ms
87d728a+dirty 1239.54 ms 1244.46 ms 4.92 ms
1573004+dirty 1254.44 ms 1261.28 ms 6.84 ms
357b71f+dirty 1277.00 ms 1286.64 ms 9.64 ms
adb21f0+dirty 1286.70 ms 1294.84 ms 8.14 ms
5cca71b+dirty 1308.50 ms 1309.56 ms 1.06 ms
9af52f2+dirty 1256.52 ms 1258.94 ms 2.42 ms

App size

Revision Plain With Sentry Diff
a4302f1+dirty 2.92 MiB 3.44 MiB 537.56 KiB
94f9b87+dirty 2.92 MiB 3.39 MiB 485.98 KiB
8ba8074+dirty 2.92 MiB 3.42 MiB 510.57 KiB
1dc092f+dirty 2.92 MiB 3.43 MiB 525.85 KiB
87d728a+dirty 2.92 MiB 3.44 MiB 538.14 KiB
1573004+dirty 2.92 MiB 3.43 MiB 525.73 KiB
357b71f+dirty 2.92 MiB 3.44 MiB 538.23 KiB
adb21f0+dirty 2.92 MiB 3.43 MiB 525.69 KiB
5cca71b+dirty 2.92 MiB 3.42 MiB 516.58 KiB
9af52f2+dirty 2.92 MiB 3.41 MiB 500.73 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 13, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 370.26 ms 404.26 ms 34.00 ms
Size 7.15 MiB 8.13 MiB 1002.18 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
575f9da+dirty 337.15 ms 370.47 ms 33.32 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
5446992+dirty 371.61 ms 390.00 ms 18.39 ms

App size

Revision Plain With Sentry Diff
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
575f9da+dirty 7.15 MiB 8.10 MiB 979.68 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
5cca71b+dirty 288.29 ms 341.60 ms 53.31 ms
8da52c9+dirty 269.29 ms 290.76 ms 21.47 ms
c1659ab+dirty 267.34 ms 337.14 ms 69.80 ms
7787a29+dirty 340.33 ms 368.82 ms 28.48 ms
a4302f1+dirty 383.10 ms 405.33 ms 22.23 ms
94f9b87+dirty 300.47 ms 353.74 ms 53.27 ms
955f10d+dirty 306.27 ms 385.83 ms 79.57 ms
8ba8074+dirty 264.25 ms 315.40 ms 51.15 ms
adb21f0+dirty 284.31 ms 347.06 ms 62.76 ms
87d728a+dirty 362.28 ms 388.30 ms 26.02 ms

App size

Revision Plain With Sentry Diff
5cca71b+dirty 7.15 MiB 8.10 MiB 972.55 KiB
8da52c9+dirty 7.15 MiB 8.09 MiB 962.83 KiB
c1659ab+dirty 7.15 MiB 8.10 MiB 972.53 KiB
7787a29+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
a4302f1+dirty 7.15 MiB 8.12 MiB 999.45 KiB
94f9b87+dirty 7.15 MiB 8.03 MiB 901.79 KiB
955f10d+dirty 7.15 MiB 8.07 MiB 946.13 KiB
8ba8074+dirty 7.15 MiB 8.08 MiB 959.34 KiB
adb21f0+dirty 7.15 MiB 8.10 MiB 980.72 KiB
87d728a+dirty 7.15 MiB 8.13 MiB 1001.74 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 17, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1294.37 ms 1312.44 ms 18.07 ms
Size 2.36 MiB 2.89 MiB 535.47 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
575f9da+dirty 1266.22 ms 1274.84 ms 8.62 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms

App size

Revision Plain With Sentry Diff
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
575f9da+dirty 2.36 MiB 2.87 MiB 520.20 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
5cca71b+dirty 1252.70 ms 1253.74 ms 1.04 ms
8da52c9+dirty 1214.59 ms 1224.90 ms 10.31 ms
c1659ab+dirty 1235.67 ms 1239.00 ms 3.33 ms
7787a29+dirty 1224.74 ms 1257.72 ms 32.98 ms
a4302f1+dirty 1260.92 ms 1276.94 ms 16.02 ms
94f9b87+dirty 1260.32 ms 1283.72 ms 23.40 ms
955f10d+dirty 1270.66 ms 1278.60 ms 7.94 ms
8ba8074+dirty 1222.44 ms 1243.82 ms 21.38 ms
adb21f0+dirty 1252.08 ms 1258.48 ms 6.40 ms
87d728a+dirty 1234.82 ms 1246.34 ms 11.52 ms

App size

Revision Plain With Sentry Diff
5cca71b+dirty 2.36 MiB 2.86 MiB 512.94 KiB
8da52c9+dirty 2.36 MiB 2.82 MiB 468.48 KiB
c1659ab+dirty 2.36 MiB 2.86 MiB 512.90 KiB
7787a29+dirty 2.36 MiB 2.89 MiB 535.45 KiB
a4302f1+dirty 2.36 MiB 2.89 MiB 534.32 KiB
94f9b87+dirty 2.36 MiB 2.83 MiB 479.26 KiB
955f10d+dirty 2.36 MiB 2.85 MiB 496.13 KiB
8ba8074+dirty 2.36 MiB 2.86 MiB 507.04 KiB
adb21f0+dirty 2.36 MiB 2.87 MiB 522.40 KiB
87d728a+dirty 2.36 MiB 2.89 MiB 535.20 KiB

@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.13.1 chore(deps): update Cocoa SDK to v8.14.1 Oct 19, 2023
@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.14.1 chore(deps): update Cocoa SDK to v8.14.2 Oct 21, 2023
krystofwoldrich
krystofwoldrich reviewed Oct 23, 2023
View reviewed changes
RNSentry.podspec
@@ -24,7 +24,7 @@ Pod::Spec.new do |s|
s.preserve_paths = '*.js'

s.dependency 'React-Core'
s.dependency 'Sentry/HybridSDK', '8.13.0'
s.dependency 'Sentry/HybridSDK', '8.14.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.14.2 is not publish as cocoa pod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getsentry/publish#2846 (comment)

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 4 times, most recently from c9ffe3e to bf34dad Compare October 30, 2023 11:22
@krystofwoldrich krystofwoldrich merged commit 1d86dd6 into main Oct 30, 2023
44 of 45 checks passed
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch October 30, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow