Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trim span descriptions. #1983

Merged
merged 4 commits into from
Apr 3, 2023
Merged

Do not trim span descriptions. #1983

merged 4 commits into from
Apr 3, 2023

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Mar 31, 2023 •
edited
Loading

  • Made sure that span descriptions are never trimmed. (for all op values, not just db spans.)
  • Removed the experimental smart_transaction_trimming option
  • Also removed some dead code that was never executed because the experimental option defaults to False.

FIxes #1974

@antonpirker antonpirker marked this pull request as ready for review March 31, 2023 12:58
sl0thentr0py
sl0thentr0py approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work!
let's just hope nobody complains about the experimental option being removed, but it's fine

@antonpirker antonpirker merged commit c4d0384 into master Apr 3, 2023
@antonpirker antonpirker deleted the antonpirker/1974-dont-truncate-span-description branch April 3, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not truncate SQL queries in Span description
2 participants
@antonpirker @sl0thentr0py