ref: Update http instrumentation name for logging #13716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, it is easier to figure out from logs if the correct or incorrect http instrumentation is added.
Now, if you see e.g. this in the logs, if users have enabled logs (`debug: true` if not using `skipOpenTelemetrySetup: true`, else e.g. `diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG)`):
```js
@opentelemetry/instrumentation-http-sentry Applying instrumentation patch for nodejs core module on require hook { module: 'http' }
@opentelemetry/instrumentation-http Applying instrumentation patch for nodejs core module on require hook { module: 'http' }
```
you can tell that that it has been double instrumenting this incorrectly.
size-limit report 📦
|
AbhiPrasad
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is easier to figure out from logs if the correct or incorrect http instrumentation is added.
Now, if you see e.g. this in the logs, if users have enabled logs (
debug: trueif not usingskipOpenTelemetrySetup: true, else using native OTEL debug logs with e.g.diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG)):you can tell that that it has been double instrumenting this incorrectly. You should never see the
@opentelemetry/instrumentation-httpentry anymore, otherwise something is wrong there.This came out of getsentry/sentry-docs#11378, I looked into various ways to debug this but there is not really an API provided by OTEL that allows us to figure this out 😬