Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Collect arrays and objects #13440

Merged
merged 1 commit into from
Aug 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 58 additions & 5 deletions packages/node/src/timetravel-worker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,55 @@ const parsedScripts = new Map<
>();
let nextFrameIsAllowed = false;

function unrollArray(objectId: string | undefined): Promise<unknown[]> {
if (!objectId) return Promise.resolve([]);

return new Promise(resolve => {
session.post(
'Runtime.getProperties',
{
objectId,
ownProperties: true,
},
(err, params) => {
const arrayProps = params.result
.filter(v => v.name !== 'length' && !isNaN(parseInt(v.name, 10)))
.sort((a, b) => parseInt(a.name, 10) - parseInt(b.name, 10))
.map(v => v?.value?.value);

resolve(arrayProps);
},
);
});
}

function unrollObject(objectId: string | undefined): Promise<Record<string, unknown>> {
if (!objectId) return Promise.resolve({});

return new Promise(resolve => {
session.post(
'Runtime.getProperties',
{
objectId,
ownProperties: true,
},
(err, params) => {
const obj = params.result
.map<[string, unknown]>(v => [v.name, v?.value?.value])
.reduce((acc, [key, val]) => {
acc[key] = val;
return acc;
}, {} as Record<string, unknown>);

resolve(obj);
},
);
});
}

const steps: Step[] = [];

function collectVariablesFromCurrentFrame(objectId: undefined | string): Promise<{ [name: string]: unknown }> {
async function collectVariablesFromCurrentFrame(objectId: undefined | string): Promise<{ [name: string]: unknown }> {
if (!objectId) {
return Promise.resolve({});
}
Expand All @@ -29,20 +75,27 @@ function collectVariablesFromCurrentFrame(objectId: undefined | string): Promise
objectId,
ownProperties: true,
},
(err, params) => {
async (err, params) => {
const vars: Record<string, unknown> = {};
for (const param of params.result) {
const name = param.name;
const value = param.value?.value;
vars[name] = value;
const value = param.value;

if (value?.type === 'object' && value.subtype === 'array') {
vars[name] = await unrollArray(value.objectId);
} else if (value?.type === 'object') {
vars[name] = await unrollObject(value.objectId);
} else { // numbers, strings
vars[name] = value?.value;
}
}
resolve(vars);
},
);
});
}

function getFileDataForCurrentFrame(
async function getFileDataForCurrentFrame(
topCallframe: inspector.Debugger.CallFrame,
parsedScript: { url?: string },
): Promise<{
Expand Down
Loading