Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix node dependencies for CI jobs #12484

Merged
merged 2 commits into from
Jun 13, 2024
Merged

ci: Fix node dependencies for CI jobs #12484

merged 2 commits into from
Jun 13, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 13, 2024

Ensure we run node-integration, remix, nextjs tests for changes in opentelemetry package.

You can see how this PR: #12477 did not trigger node-integration tests 😬

Ensure we run node-integration, remix, nextjs tests for changes in opentelemetry package.
@mydea mydea requested review from Lms24 and AbhiPrasad June 13, 2024 14:35
@mydea mydea self-assigned this Jun 13, 2024
@mydea mydea changed the title ci: Fix node dependencies ci: Fix node dependencies for CI jobs Jun 13, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mydea mydea enabled auto-merge (squash) June 13, 2024 15:10
@mydea mydea merged commit 073b649 into develop Jun 13, 2024
111 checks passed
@mydea mydea deleted the fn/fix-node-ci-deps branch June 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants