Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: linter issue #547

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: linter issue #547

wants to merge 3 commits into from

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Jun 26, 2024

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

@buenaflor buenaflor requested a review from a team June 26, 2024 21:26
BYK
BYK suggested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this test needs to check for not null condition.

src/utils/__tests__/version.test.ts Outdated Show resolved Hide resolved
@vaind @BYK
Update src/utils/__tests__/version.test.ts
8f7a924 
Co-authored-by: Burak Yigit Kaya <ben@byk.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BYK BYK BYK requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaind @BYK