Counter is too large on Query View/Source pages #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldutra
approved these changes
Jul 13, 2020
|
Dimensions I chose are quite arbitrary. Counters with smaller numbers still look quite big, but when there are 5-8-digits numbers, or longer label, or second row - it's much better. I worried that it may be even too small in some cases. |
|
This PR broke the counter visualization entirely on Safari (both mobile and desktop). I'm actually surprised nobody else has noticed yet but I guess not too many people are running the latest version of Redash and use Safari. I'll try to fix and will submit a PR |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Closes #5031
Mobile & Desktop Screenshots/Recordings (if there are UI changes)