Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up stopping postgres14 container #528

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Speed up stopping postgres14 container #528

merged 1 commit into from
Oct 27, 2023

Conversation

lognaturel
Copy link
Member

Closes #419

What has been done to verify that this works as intended?

docker compose build postgres14
docker compose up -d postgres14
docker compose stop

Why is this the best possible solution? Were any other approaches considered?

This is using all the same strategies as described in #417 I delayed this one because I didn't have a local setup at the time.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

As far as I know, there's no risk.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

sadiqkhoja
sadiqkhoja approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@sadiqkhoja sadiqkhoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried it locally, works great

@lognaturel lognaturel merged commit 15e519a into getodk:next Oct 27, 2023
1 check passed
@lognaturel lognaturel deleted the fast-postgres-shutdown branch October 27, 2023 20:01
@matthew-white matthew-white linked an issue Oct 27, 2023 that may be closed by this pull request
speed up stopping postgres14 container #419
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadiqkhoja sadiqkhoja sadiqkhoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

speed up stopping postgres14 container
2 participants
@lognaturel @sadiqkhoja