Remove Google Drive backups #375
Merged
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #323. There will also be changes in Backend and Frontend.
ktuite
approved these changes
Jan 3, 2023
yanokwa
pushed a commit
to yanokwa/odk-central
that referenced
this pull request
Feb 25, 2023
See getodk#323. There will also be changes in Backend and Frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #323.
What has been done to verify that this works as intended?
I don't think there's a lot to verify here. With this PR, Central will no longer run the lib/bin/backup.js script in central-backend. We will remove that script in a separate Backend PR.
Why is this the best possible solution? Were any other approaches considered?
We have to remove run-backup.sh from the crontab. That's the only place that run-backup.sh is used, so we can also remove run-backup.sh.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This change should be low-risk. The main regression risks will come with the changes to central-backend, which will happen in a separate PR.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
getodk/docs#1535
Before submitting this PR, please make sure you have: