Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide some entity conflict functionality from project viewers #538

Closed
matthew-white opened this issue Oct 29, 2023 · 4 comments · Fixed by getodk/central-frontend#896
Closed

Hide some entity conflict functionality from project viewers #538

matthew-white opened this issue Oct 29, 2023 · 4 comments · Fixed by getodk/central-frontend#896
Assignees
@matthew-white
Labels
behavior verified Behavior has been manually verified entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

matthew-white commented Oct 29, 2023 •
edited
Loading

This issue is to account for project viewers for the following stories in the release criteria:

See the release criteria for details about what a project viewer should and should not see.

Original issue description

Right now, a project viewer can see the "Review parallel updates" button in the entities table. Clicking the button shows a modal that allows the user to update the entity or mark it as resolved. However, project viewers can't do those things. I think we should hide the "Review parallel updates" button from project viewers. (We could use the canUpdate prop of the EntityMetadataRow component for that.) Should we also hide the warning icon from them?

I've also asked about this in the release criteria.
@matthew-white matthew-white added needs discussion Discussion needed before work can begin frontend Requires a change to the UI entities Multiple Encounter workflows labels Oct 29, 2023
@matthew-white

This comment was marked as outdated.

Sign in to view
@matthew-white

This comment was marked as outdated.

Sign in to view
@matthew-white matthew-white changed the title Hide "Review parallel updates" button from project viewer Hide some entity conflict functionality from project viewers Nov 8, 2023
@matthew-white matthew-white removed the needs discussion Discussion needed before work can begin label Nov 8, 2023
@matthew-white matthew-white added the needs testing Needs manual testing label Nov 23, 2023
@matthew-white matthew-white self-assigned this Nov 27, 2023
matthew-white added a commit to getodk/central-frontend that referenced this issue Nov 27, 2023
@matthew-white
Do not allow project viewer to update entity or mark it as resolved
29d1fd4 
Closes getodk/central#538.
@matthew-white matthew-white mentioned this issue Nov 27, 2023
Merged
2 tasks
@dbemke
Copy link

dbemke commented Dec 1, 2023

Tested with success!

@srujner
Copy link

srujner commented Dec 1, 2023

Tested with success!

@srujner srujner added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Dec 1, 2023
This was referenced Dec 6, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-white matthew-white

Labels
behavior verified Behavior has been manually verified entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
ODK Central
Status: ✅ done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not allow project viewer to update entity or mark it as resolved getodk/central-frontend
3 participants
@matthew-white @dbemke @srujner