Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show updating submission link in entity feed #879

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Oct 24, 2023

Closes #
Screen Shot 2023-10-24 at 10 47 45 AM

What has been done to verify that this works as intended?

Trying it out and adding tests.

Why is this the best possible solution? Were any other approaches considered?

I don't think this is the best -- this component is complicated and confusing.

It can handle entity events.
It can also handle artificial events for submission creation/approval when that is relevant to an entity...
It can handle events about entities that contain submission info in the details.
The submissions in the two cases above can be available or deleted, and can show the instance name or instance id depending.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Getting some warnings running the full test suite:

WARN LOG: '[Vue warn]: Unhandled error during execution of render function', '
', ' at <PageSection', 'id="entity-activity"', '>', '
', ' at <EntityActivity>', '
', ' at <PageBody>', '
', ' at <EntityShow', 'projectId="1"', 'datasetName="trees"', 'uuid="e"', ' ...', '>', '
', ' at <VTUROOT>'

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interactive review with @matthew-white

src/components/entity/activity.vue Outdated Show resolved Hide resolved
src/components/entity/feed-entry.vue Outdated Show resolved Hide resolved
test/components/entity/feed-entry.spec.js Outdated Show resolved Hide resolved
@ktuite ktuite marked this pull request as ready for review October 25, 2023 00:08
@ktuite ktuite merged commit 9091932 into master Oct 25, 2023
1 check passed
@ktuite ktuite deleted the ktuite/entity_feed_sub_update branch October 25, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants