Use property odataName in entities table #807
Merged
+49
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
approved these changes
May 23, 2023
| @@ -3,6 +3,12 @@ import { comparator } from 'ramda'; | |||
| import { dataStore } from './data-store'; | |||
| import { extendedProjects } from './projects'; | |||
|
|
|||
| const normalizeProperty = (property) => ({ | |||
| odataName: property.name, | |||
There was a problem hiding this comment.
odataName: property.odataName ?? property.name
There was a problem hiding this comment.
property.name is the default odataName. The defaults are merged with property using ...property, so if property specifies its own odataName, it will overwrite the default.
Confirmed that the value of the property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #793.
What has been done to verify that this works as intended?
A new test. Once it's on staging, I can verify it against the entity mentioned in the issue.
Why is this the best possible solution? Were any other approaches considered?
Backend returns the
odataName, so Frontend just needs to use it.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The risk of regression should be low.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No changes needed.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes