Adding Python to OData modal and changing text #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Feb 24, 2023
| @@ -213,272 +200,3 @@ export default { | |||
| } | |||
| </i18n> | |||
|
|
|||
| <!-- Autogenerated by destructure.js --> | |||
There was a problem hiding this comment.
Probably no need to delete this section even if things are broken for non-English locales, unless tests are failing. I'll update this section when I update translations before regression testing.
| // The text of {python} is "Python". The text of {excel} is "Excel". | ||
| // {powerBi}, {r}, {excel} and {python} are all links. | ||
| "OData is a standard for transferring data between tools and services. Free and powerful analysis tools like {powerBi}, {excel}, {python}, and {r} can fetch data via OData for analysis.", | ||
| "To connect to this form’s OData feed, select your tool and copy the link into it." |
| "here": "here" | ||
| } | ||
| ], | ||
| "python": "To connect to Central from Python, we recommend {pyODK}. pyODK is the official Python client for Central and it makes common data analysis and workflow automation tasks simple.", |
There was a problem hiding this comment.
How about a translator comment here:
{pyODK} is a link. Its text is "pyODK".
| } | ||
| ], | ||
| "python": "To connect to Central from Python, we recommend {pyODK}. pyODK is the official Python client for Central and it makes common data analysis and workflow automation tasks simple.", | ||
| "r": "To connect to Central from R, we recommend {ruODK}. ruODK is developed and supported by ODK community members.", |
There was a problem hiding this comment.
Probably a translator comment here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #740. This will show up on the submissions page and the entities page.
What has been done to verify that this works as intended?
Tests and looking at it.
Why is this the best possible solution? Were any other approaches considered?
Pretty straightforward template and text changes following guidance in issue.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Adds python! Less text.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes