Update Submissions response #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
commented
Feb 25, 2023
This was
linked to
issues
Feb 27, 2023
read logical submission from database on submission update
sadiqkhoja
commented
Feb 28, 2023
Comment on lines
+156
to
+160
| // Helper function to assign submission.currentVersionSubmitter to submission.currentVersion.submitter | ||
| // Current there is no way to create such complex object using `extender` and `unjoiner` framework functions | ||
| const assignCurrentVersionSubmitter = (x) => x.withAux('currentVersion', x.aux.currentVersion.withAux('submitter', x.aux.currentVersionSubmitter)); | ||
|
|
||
| const _get = extender(Submission, Submission.Def.into('currentVersion'))(Actor.into('submitter'), Actor.alias('current_version_actors', 'currentVersionSubmitter'))((fields, extend, options, projectId, xmlFormId, draft) => sql` |
There was a problem hiding this comment.
I might be wrong here, do you know if there is a way to use extender to set currentVersion.submitter?
There was a problem hiding this comment.
I'm not sure actually! I can't think of a similar example of nested extended metadata, so maybe not.
matthew-white
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #417, #481, #590
What has been done to verify that this works as intended?
Updated integration tests
Why is this the best possible solution? Were any other approaches considered?
Detailed discussion on Slack
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
Updated.
Before submitting this PR, please make sure you have:
make test-fulland confirmed all checks still pass OR confirm CircleCI build passes