Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force-process entity submissions held in backlog #1172

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Aug 20, 2024

Main PR to close getodk/central#682 following PR #1171

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite
Copy link
Member Author

ktuite commented Aug 20, 2024

Thoughts on force-processing when entities can be soft-deleted:

  • Don't force-apply things in the backlog that are about soft-deleted entities.
  • Check what happens with soft-deleted submissions (which can happen today via form-purging)
  • Consider deleting things from the backlog when the entity that they reference are purged. (When entity purging happens)

Base automatically changed from ktuite/improve_offline_entities to master August 21, 2024 18:12
@ktuite ktuite force-pushed the ktuite/force-process-entity-subs branch from 6c0404d to 9c297b7 Compare August 21, 2024 19:18
@ktuite ktuite marked this pull request as ready for review August 23, 2024 20:33
lib/task/process-backlog.js Show resolved Hide resolved
lib/task/process-backlog.js Outdated Show resolved Hide resolved
lib/model/query/entities.js Outdated Show resolved Hide resolved
lib/model/query/entities.js Show resolved Hide resolved
lib/model/query/entities.js Outdated Show resolved Hide resolved
test/integration/api/offline-entities.js Outdated Show resolved Hide resolved
@ktuite ktuite merged commit fb78290 into master Aug 26, 2024
5 checks passed
@ktuite ktuite deleted the ktuite/force-process-entity-subs branch August 26, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a task to process offline entity submissions that have been held for a certain amount of time
2 participants