Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create audit log entry when password is invalidated #736

Closed
matthew-white opened this issue Jan 21, 2023 · 1 comment · Fixed by #737
Closed

Create audit log entry when password is invalidated #736

matthew-white opened this issue Jan 21, 2023 · 1 comment · Fixed by #737
Assignees
Labels
behavior verified Behavior has been manually verified

Comments

@matthew-white
Copy link
Member

matthew-white commented Jan 21, 2023

/v1/users/reset/initiate initiates a password reset. If ?invalidate=true is specified, then the existing password is also immediately invalidated. The results of /v1/users/reset/initiate don't appear in the audit log. I think it makes sense that initiating a password reset isn't logged. However, if a password is invalidated, I think it'd be a good idea to log that, since that results in an immediate change to an existing resource. Only sitewide administrators can invalidate another user's password.

In terms of which action is logged, I think we could use user.update. Changing a password also logs user.update.


Note for the QA team: This change can be verified by clicking "Reset password" in the actions dropdown for a user on the Users page. Resetting a user's password from that page will invalidate it, which should now result in a new entry in the server audit log.

@dbemke
Copy link

dbemke commented Jan 25, 2023

Tested with Success!
Verified Cases:

  • "Update Details" present is System Audit Log after resetting the password

@srujner srujner added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

3 participants