Performance: Allow large sets of JSON docs without StackOverflows #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
force-pushed
the
performance/remove-stackoverflow-for-large-docsets
branch
from
2e52445
to
ebf4901
Compare
bblommers
force-pushed
the
performance/remove-stackoverflow-for-large-docsets
branch
from
ebf4901
to
9b48238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation would call
parse()recursively for every document at the root level.If a file contains more than 300 documents, that quickly becomes a problem.
This PR changes the JsonParser to yield documents instead as and when they come, improving performance and removing the need for any recursion