fix: message of the error type in required fields contains "or not to be present" #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot to be present" (#666)
fenollp
reviewed
Nov 16, 2022
| } | ||
|
|
||
| if !markRequiredProperty(r.Value, k, schema.Required) { | ||
| for _, a := range schema.AnyOf { |
fenollp
reviewed
Nov 16, 2022
| msg.WriteString("Field must be set to ") | ||
| msg.WriteString(schema.Type) | ||
|
|
||
| if !schema.isThisRequired { |
There was a problem hiding this comment.
I'd prefer to figure out this boolean only when building the error, not beforehand.
There was a problem hiding this comment.
- Then at each error you will have to make calculations. This is an additional expense of computing resources.
- At this point we don't know anything about parent Schemas. They will have to be wired somehow.
Do you have any ideas how to do it better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #666