Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support coinmarketcap slugs #1684

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

shamoon
Copy link
Collaborator

@shamoon shamoon commented Jul 14, 2023

Proposed change

This allows specifying slug with coinmarketcap since crypto does dumb things like reuse their crypto symbols. So this supports e.g.

          widget:
               type: coinmarketcap
               slugs: [chia-network, uniswap]
               defaultinterval: "1h"
               key: ...
Screenshot 2023-07-13 at 9 30 24 PM Screenshot 2023-07-13 at 9 30 11 PM

Closes #1683

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (please explain)

Checklist:

  • If adding a service widget or a change that requires it, I have added a corresponding PR to the documentation here: benphelps/homepage-docs@1658504
  • If adding a new widget I have reviewed the guidelines.
  • If applicable, I have checked that all tests pass with e.g. pnpm lint.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon merged commit ae4a2e3 into main Jul 14, 2023
1 check passed
@shamoon shamoon deleted the feature-coinmarketcap-slugs branch July 14, 2023 05:43
@insunaa
Copy link

insunaa commented Jul 14, 2023

Thank you very much for this incredibly fast fix/feature! <3

Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Coinmarketcap Widget using non-unique key
2 participants