Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override config directory with env var. #1673

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Override config directory with env var. #1673

merged 1 commit into from
Jul 11, 2023

Conversation

jnsgruk
Copy link
Contributor

@jnsgruk jnsgruk commented Jul 10, 2023

Proposed change

Until this change, the config directory was assumed to be located at '$PWD/config'. This patch retains that default behaviour, but enables users/devs to override that behaviour by setting the HOMEPAGE_CONFIG_DIR variable.

Closes # (issue)

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (please explain)

Checklist:

  • If adding a service widget or a change that requires it, I have added a corresponding PR to the documentation here:
  • If adding a new widget I have reviewed the guidelines.
  • If applicable, I have checked that all tests pass with e.g. pnpm lint.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Until this change, the config directory was assumed
to be located at '/config'. This patch retains that
default behaviour, but enables users/devs to override
that behaviour by setting the HOMEPAGE_CONFIG_DIR
variable.
@shamoon
Copy link
Collaborator

shamoon commented Jul 10, 2023

I suppose this is fine, is your use case for running 'bare metal'? Not much point for a containerized install

@jnsgruk
Copy link
Contributor Author

jnsgruk commented Jul 10, 2023

Yep that's correct. I've set homepage up on NixOS running under systemd, and currently I'm applying this patch as part of a custom package. (Details here and here if you're interested)

@shamoon shamoon merged commit 2d8af6e into gethomepage:main Jul 11, 2023
1 check passed
@jnsgruk jnsgruk deleted the conf-dir-override branch July 11, 2023 07:10
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants