Run ci smoke tests on armv7 #59
Conversation
There was a problem hiding this comment.
This patch doesn't actually do anything useful because I've optimized things away in b5fe043 😅
We will need to add usage of ${{ matrix.target }} again!
bonomat
force-pushed
the
armv7
branch
2 times, most recently
from
cc2c58b
to
8f9ec90
Compare
|
Converted to draft because something is not working:
Any idea? |
You can't run an ARM binary on a x64 processor. You would need to start up an emulator like QEMU to do that. In the past we simply skipped the smoke test for certain targets. |
Oh makes sense, I didn't know that all targets run on |
rust-toolchain.toml
Outdated
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
| channel = "1.54" | |||
There was a problem hiding this comment.
1.55 is the latest release, any reason why you want 1.54 here?
There was a problem hiding this comment.
No particular reason. Changed to 1.55 and updated locally :)
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
There was a problem hiding this comment.
If we have a rust-toolchain.toml file, it would be good to do an explicit install step instead of "implying" this with the first call to cargo. Reason being that the cache action works out the cache key based on the installed rust version and that would happen before the first cargo invocation, effectively creating the wrong cache key for what is actually being used.
See actions-rs/toolchain#126 + recommended solution.
We cannot run the smoke tests for arm as all targets on Github are x86_64
Imho it's a common assumption that our tool will run on a RPi and we should ensure that it keeps building for this platform.