Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSW / GetRecords / Number of matches in page info #7937

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

fxprunayre
Copy link
Member

Follow up of #7599

result.hits().hits().size() returns number of records in response, not total hits matching search. numberOfRecordsMatched is wrong.

  <csw:SearchResults numberOfRecordsMatched="10" numbe

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Follow up of #7599

`result.hits().hits().size()` returns number of records in response, not total hits matching search. `numberOfRecordsMatched` is wrong.

```
  <csw:SearchResults numberOfRecordsMatched="10" numbe
```
@fxprunayre fxprunayre added this to the 4.4.4 milestone Apr 9, 2024
Copy link

sonarcloud bot commented Apr 9, 2024

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine.

In 4.2.x and works fine:

So probably this is a regression related to the upgrade to Elasticsearch 8.

@fxprunayre fxprunayre merged commit e63f0b3 into main Apr 10, 2024
9 checks passed
@fxprunayre fxprunayre deleted the csw-numberOfRecordsMatched branch April 10, 2024 06:44
@fxprunayre fxprunayre changed the title CSW / GetRecords / Number of matches is not total match CSW / GetRecords / Number of matches in page info Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants