Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML syntax in users.html #7764

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix HTML syntax in users.html #7764

merged 1 commit into from
Feb 19, 2024

Conversation

juanluisrp
Copy link
Contributor

@juanluisrp juanluisrp commented Feb 15, 2024 •
edited
Loading

Fix HTML syntax removing extra quote. Then remove non-needed form-control class and add class checkbox to the div as indicated by Bootstrap 3.4. Wrap the input with label to center it vertically.

Before:
image

After:
image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@juanluisrp juanluisrp self-assigned this Feb 15, 2024
@juanluisrp juanluisrp added the bug label Feb 15, 2024
@juanluisrp juanluisrp added this to the 4.4.3 milestone Feb 15, 2024
@juanluisrp juanluisrp marked this pull request as draft February 15, 2024 11:36
@juanluisrp
Fix alignment of user enabled checkbox
4f780b3 
* Fix HTML syntax in users.html. Fix extra quote and remove form-control class from checkbox.
* Fix alignment of checkbox
@juanluisrp juanluisrp marked this pull request as ready for review February 15, 2024 12:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@juanluisrp juanluisrp merged commit 87ba1ff into main Feb 19, 2024
9 checks passed
@juanluisrp juanluisrp deleted the users-fix-html branch February 19, 2024 09:09
This was referenced Feb 19, 2024
Merged
Merged
juanluisrp added a commit that referenced this pull request Feb 19, 2024
@geonetworkbuild @juanluisrp
[Backport 4.2.x] Fix alignment of user enabled checkbox (#7773)
2a4eac1 
* Fix HTML syntax in users.html. Fix extra quote and remove form-control class from checkbox.
* Fix alignment of checkbox

Backport #7764.

Co-authored-by: Juan Luis Rodríguez <juanluisrp@gmail.com>
juanluisrp added a commit that referenced this pull request Feb 19, 2024
@geonetworkbuild @juanluisrp
[Backport 3.12.x] Fix alignment of user enabled checkbox (#7772)
51eafeb 
* Fix HTML syntax in users.html. Fix extra quote and remove form-control class from checkbox.
* Fix alignment of checkbox

Backport #7764.

Co-authored-by: Juan Luis Rodríguez <juanluisrp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelGabriel MichelGabriel Awaiting requested review from MichelGabriel

Assignees

@juanluisrp juanluisrp

Labels
backport 3.12.x backport 4.2.x bug
Projects
None yet
Milestone
4.4.3
Development

Successfully merging this pull request may close these issues.
1 participant
@juanluisrp