Home page / sort topic categories and INSPIRE themes facets alphabetically #7569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelGabriel
approved these changes
Dec 21, 2023
|
When removing in the configuration of the facets Not sure if it's useful to keep the old behaviour with some configuration, what do you think @fxprunayre? |
|
@fxprunayre I've improved the pull request to use the sorter per facet using the configuration provided: 1da4ec2 |
fxprunayre
reviewed
Jan 4, 2024
Comment on lines
187
to
198
|
|
||
| this.sortByQuantity = function (agg, bucket) { | ||
| return function (facet) { | ||
| return facet.count; | ||
| }; | ||
| }; | ||
|
|
||
| this.sortByQuantityDesc = function (agg, bucket) { | ||
| return function (facet) { | ||
| return -1 * facet.count; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
We don't need that as we can sort server side by facet configuration using "order" : { "_count" : "desc" } or "order" : { "_count" : "asc" }. So we can remove this and use the same sort method for all facet directive
There was a problem hiding this comment.
@fxprunayre updated the pull request with your comments, thanks.
fxprunayre
reviewed
Jan 4, 2024
web-ui/src/main/resources/catalog/components/elasticsearch/directives/FacetDirective.js
Outdated
Show resolved
Hide resolved
…ectives/FacetDirective.js Co-authored-by: François Prunayre <fx.prunayre@gmail.com>
…cally - remove not required code
fxprunayre
approved these changes
Jan 4, 2024
josegar74
added a commit
that referenced
this pull request
Jan 4, 2024
…abetically (#7569) * Home page / sort topic categories and INSPIRE themes facets alphabetically * Home page / use facets configuration to sort alphabetically or by quantity * Update web-ui/src/main/resources/catalog/components/elasticsearch/directives/FacetDirective.js Co-authored-by: François Prunayre <fx.prunayre@gmail.com> * Home page / sort topic categories and INSPIRE themes facets alphabetically - remove not required code --------- Co-authored-by: François Prunayre <fx.prunayre@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the topic categories and INSPIRE themes filters in the home page seem sorted by the amount of metadata in each category. This change adds support to sort the values alphabetically.
Before:
After:
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation