Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata extents API / Make configurable to display the metadata bboxes using geodesic extents for local projections. #7560

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

josegar74
Copy link
Member

@josegar74 josegar74 commented Dec 18, 2023

Similar to #6982, but for the metadata map extent API.

Adds a new setting to configure to use the geodesic extents when using a local projection (for global projections: EPSG:4326 and EPSG:3857, the setting is ignored).

By default, the setting is disabled, displaying the extents planars (being similar to #6982).

setting-geodesic-extents

With the setting disabled, using a local projection:

setting-disabled

With the setting enabled, using a local projection:

setting-enabled


Includes Sonarlint improvements.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

…es using geodesic extents for local projections.
@josegar74 josegar74 added this to the 4.4.2 milestone Dec 18, 2023
@josegar74 josegar74 requested review from jodygarnett, fxprunayre and MichelGabriel and removed request for MichelGabriel December 18, 2023 13:57
Copy link
Contributor

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see what the code is doing; would like to see a test case to confirm the math.
It will be easier to write a test case, and follow the logic, if a new method is added.

@jodygarnett
Copy link
Contributor

Thanks for addressing my feedback; do we wait for review from @fxprunayre also?

@fxprunayre fxprunayre merged commit 2af1efb into geonetwork:main Jan 4, 2024
6 checks passed
josegar74 added a commit that referenced this pull request Jan 4, 2024
… bboxes using geodesic extents for local projections. (#7560)

* Metadata extents API / Make configurable to display the metadata bboxes using geodesic extents for local projections.

* Add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants