-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't display header menu and footer in single metadata PDF export #7532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem like you forgot to also fix the following link
Related to the following which has recently been merged #7481. Also seems like this merge caused conflicts in this PR |
@ianwallen it seems can be used a CSS class |
…code refactor. Related to geonetwork#7521
@ianwallen I applied your suggestions, the solution stated above to use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes and it works.
I do find it odd that the PDF does not have a permalink back to the original metadata document. But that is something we can add in another PR if required.
Related to #7521
The single metadata PDF export adds header toolbar and footer, as it's used the metadata full view formatter that uses the HTML layout.
In the PDF export doesn't seem to make sense to add these elements.
Before:
After:
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation