Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display header menu and footer in single metadata PDF export #7532

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

josegar74
Copy link
Member

Related to #7521

The single metadata PDF export adds header toolbar and footer, as it's used the metadata full view formatter that uses the HTML layout.

In the PDF export doesn't seem to make sense to add these elements.

Before:

pdf-report-before

After:

pdf-report-after

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Copy link
Contributor

@ianwallen ianwallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web/src/main/webapp/xslt/skin/default/skin.xsl Outdated Show resolved Hide resolved
web/src/main/webapp/xslt/skin/default/skin.xsl Outdated Show resolved Hide resolved
@ianwallen
Copy link
Contributor

Related to the following which has recently been merged #7481. Also seems like this merge caused conflicts in this PR

@josegar74
Copy link
Member Author

@ianwallen it seems can be used a CSS class hidden-print, I'll rework the pull request to update the code.

@josegar74
Copy link
Member Author

@ianwallen I applied your suggestions, the solution stated above to use a hidden-print CSS class caused other side effects due to a new CSS file that needed to be included, so I discarded it.

Copy link
Contributor

@ianwallen ianwallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes and it works.

I do find it odd that the PDF does not have a permalink back to the original metadata document. But that is something we can add in another PR if required.

@ianwallen
Copy link
Contributor

Sorry - I guess there is a link to the metadata record. It is a small link that was easily missed.
image

@josegar74 josegar74 merged commit bc20706 into geonetwork:main Dec 13, 2023
6 checks passed
josegar74 added a commit that referenced this pull request Dec 13, 2023
…rt (#7532)

* Don't display header menu and footer in single metadata PDF export. Related to #7521

* Don't display header menu and footer in single metadata PDF export / code refactor. Related to #7521
ianwallen pushed a commit that referenced this pull request Dec 14, 2023
…rt (#7532)

* Don't display header menu and footer in single metadata PDF export. Related to #7521

* Don't display header menu and footer in single metadata PDF export / code refactor. Related to #7521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants