Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show less facet values #7497

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

josegar74
Copy link
Member

Currently the facet filters allow to display more values, but doesn't allow to reduce the number of values listed, unless refreshing the full page.

This change adds a less option to reduce the list to the previous number of elements.

Previously:

facets-1

With the change:

facets-2

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Copy link
Contributor

@MichelGabriel MichelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josegar74 if you could add an extra class on line 139 in facets.html that would make it perfect.

Then it will look like this:
class="gn-facet-more d-inline-block"

This will remove the underline on hover be too wide.

@josegar74
Copy link
Member Author

@MichelGabriel added the style, thanks for the review.

@fxprunayre fxprunayre merged commit 9bab082 into geonetwork:main Dec 4, 2023
6 checks passed
josegar74 added a commit that referenced this pull request Dec 4, 2023
* Add option to show less facet values

* Add option to show less facet values - add additional styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants