Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSPIRE Atom Search - add missing filter by feed dataset identifiers #7492

Merged
merged 2 commits into from
Dec 1, 2023
Merged

INSPIRE Atom Search - add missing filter by feed dataset identifiers #7492

merged 2 commits into from
Dec 1, 2023

Conversation

josegar74
Copy link
Member

Follow up of #6395

The INSPIRE Atom Search service, when providing the service metadata uuid was not filtering the related dataset feeds, returning all the dataset feeds available.

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in mannual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 added this to the 4.4.1 milestone Nov 15, 2023
@josegar74 josegar74 modified the milestones: 4.4.1, 4.4.2 Nov 22, 2023
juanluisrp
juanluisrp approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@juanluisrp juanluisrp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added a suggestion to escape the identifiers to json valid values.

inspire-atom/src/main/java/org/fao/geonet/services/inspireatom/AtomSearch.java Outdated Show resolved Hide resolved
@josegar74 josegar74 merged commit 6da0c70 into geonetwork:main Dec 1, 2023
6 checks passed
josegar74 added a commit that referenced this pull request Dec 1, 2023
@josegar74 @juanluisrp
[BP] INSPIRE Atom Search - add missing filter by feed dataset identif…
37c4a0b 
…iers (#7492)

* INSPIRE Atom Search - add missing filter by feed dataset identifiers

* Fix sonarlint warnings and format code

---------

Co-authored-by: Juan Luis Rodríguez <juanluisrp@gmail.com>
@juanluisrp juanluisrp mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisrp juanluisrp juanluisrp approved these changes

@fxprunayre fxprunayre Awaiting requested review from fxprunayre

Assignees
No one assigned
Labels
backport 4.2.x
Projects
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@josegar74 @juanluisrp