Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List styling for related records #7442

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

MichelGabriel
Copy link
Contributor

Add a list styling to related records when the data-layout="title"

Before:

gn-related-before

After:

gn-related-after

Related to: osgeonl/geonetwork-dutch-skin#76

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in mannual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Add a list styling to related records when the `data-layout="title"`
@josegar74
Copy link
Member

@MichelGabriel the layout looks better, but the default view seems using it to display parent metadata in the header of the record view also. And this looks a bit odd with the change.

list-layout-1

Maybe can be applied some specific styling when the element is contained in the header to display it as previously?

list-layout-3

The other relations displayed below, looks better when using this layout:

list-layout-2

@josegar74 josegar74 merged commit 11ff830 into geonetwork:main Oct 25, 2023
6 checks passed
josegar74 pushed a commit that referenced this pull request Oct 25, 2023
* List styling for related records

Add a list styling to related records when the `data-layout="title"`

* No list styling when the related list is contained in the top of the page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants