Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor / Remove extra space on mandatory add action #7438

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

fxprunayre
Copy link
Member

If button label is not empty, do not add unneeded space. This was more visible on mandatory elements.

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in mannual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

If button label is not empty, do not add unneeded space. This was more visible on mandatory elements.
@fxprunayre fxprunayre added this to the 4.4.1 milestone Oct 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks fine, although not tested as not very clear how to configured a label to display in the add elements.

@fxprunayre
Copy link
Member Author

Code change looks fine, although not tested as not very clear how to configured a label to display in the add elements.

You can test it with a non existing mandatory element eg. remove the abstract in XML view and check the + in full view

image

@josegar74 josegar74 merged commit 92295e5 into main Nov 8, 2023
10 checks passed
josegar74 pushed a commit that referenced this pull request Nov 8, 2023
If button label is not empty, do not add unneeded space. This was more visible on mandatory elements.
@fxprunayre fxprunayre deleted the 4-editoraddlabelspace branch November 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants