Fix write after response commit on proxy response #7353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Links table is empty an 500 error happens: java.lang.IllegalStateException: Cannot call sendError() after the response has been committed This is caused because the response.sendError(...) method is being called twice when the Links table has no entries. This commits fix this error calling the method only once. In addition, it removes unnecessary info returned to the client. Signed-off-by: Juan Luis Rodríguez <juanluisrp@gmail.com>
josegar74
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Works fine, now when the table is empty, returns the following error:
{
"servlet":"HttpProxy",
"message":"The proxy is configured with DB_LINK_CHECK mode but the MetadataLink table is empty. Administrator may need to analyze record links from the admin console in order to register URL allowed by the proxy.",
"url":"/geonetwork/proxy",
"status":"403"
}
But the UI for example to add a WMS service in the map viewer doesn't show the message, but that is another stuff:
URL .... returned status ''. You should check the URL or check that the service is running.
josegar74
pushed a commit
that referenced
this pull request
Sep 22, 2023
When the Links table is empty an 500 error happens: java.lang.IllegalStateException: Cannot call sendError() after the response has been committed This is caused because the response.sendError(...) method is being called twice when the Links table has no entries. This commits fix this error calling the method only once. In addition, it removes unnecessary info returned to the client. Signed-off-by: Juan Luis Rodríguez <juanluisrp@gmail.com>
josegar74
pushed a commit
that referenced
this pull request
Sep 22, 2023
When the Links table is empty an 500 error happens: java.lang.IllegalStateException: Cannot call sendError() after the response has been committed This is caused because the response.sendError(...) method is being called twice when the Links table has no entries. This commits fix this error calling the method only once. In addition, it removes unnecessary info returned to the client. Signed-off-by: Juan Luis Rodríguez <juanluisrp@gmail.com>
juanluisrp
deleted the
fix/proxy-send-error-after-response-comitted-exception
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Links table is empty an 500 error happens when using the proxy:
This is caused because the
response.sendError(...)method is being called twice when theLinkstable has no entries. This commits fix this error calling the method only once.In addition, it removes unnecessary info returned to the client.