Prevent invalid date written into xml

[wangf1122]

This issue happens in both GN4 and lower versions (3.12).

If the user select datetime for the field, pick a time but not a date.

Switch to xml view first time, the field will just render empty string which has no ill effect on the Java side because Java ISO date will just use default date 1970-01-01

switch between xml view and UI view second time (or validate the records couple of times).
The "Invalid Date" string was put to the xml.

This can cause the xml parser on Java side returns some exception.

This "Invalid Date" is some error message when trying to initiate a Date object in Javascript and this can be ignored

[josegar74]

@wangf1122 it works, but maybe a better solution to avoid checking the text of the error could be to update the following code:

core-geonetwork/web-ui/src/main/resources/catalog/components/edit/datepicker/DatePickerDirective.js

Lines 181 to 185 in 79865d1

	scope.date = new Date(
	moment(isDateTime ? tokens[0] : scope.value)
	.utc()
	.format()
	);

Checking moment(isDateTime ? tokens[0] : scope.value).isValid(), if it is not valid assign scope.date = '' instead of the previous assignment, that should not require further changes.

[wangf1122]

@josegar74

Yeah, I think the code you showed is the better place. It is where the variable was initiated. I tested and it works good. I did make the code update to this comment

[josegar74]

@wangf1122 my proposal was a bit different, to avoid checking the text value Invalid date:

if (moment(isDateTime ? tokens[0] : scope.value).isValid()) {
 scope.date = new Date( 
   moment(isDateTime ? tokens[0] : scope.value) 
     .utc() 
     .format() 
 ); 
} else {
 scope.date = '';
}

[wangf1122]

@josegar74

I have tested your code and works good. I made another commit for it.