Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP] Switch from iText to OpenPDF for PDF map rendering #6392

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

juanluisrp
Copy link
Contributor

Backport of #6343

Original PR from @jodygarnett.

@juanluisrp juanluisrp added dependencies Pull requests that update a dependency file backport 3.12.x labels Jun 14, 2022
@juanluisrp juanluisrp added this to the 3.12.6 milestone Jun 14, 2022
@juanluisrp
Copy link
Contributor Author

Tested in the metadata details -> export to PDF, search results -> print pdf and print map tool.

core/pom.xml Outdated Show resolved Hide resolved
web/pom.xml Outdated Show resolved Hide resolved
import io.swagger.annotations.*;
import jeeves.server.context.ServiceContext;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes to import order - does geonetwork have a standard that we can configure IDE to follow?

Copy link
Contributor

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove excludes from mapfish-print dependency

Remove itext exclusions becasue it isn't a depencency of mapfish's print-lib
2.2.0 anymore
@juanluisrp
Copy link
Contributor Author

I have the impression that printing with OpenPDF is slower than using the current version of iText included in GN. Did you have the same experience when testing the PR for main @josegar74, @fxprunayre?

@juanluisrp juanluisrp merged commit 25d5d53 into geonetwork:3.12.x Jun 15, 2022
@juanluisrp juanluisrp deleted the backports/3.12.x/openpdf branch June 15, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants