Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema plugin / Add schema bean to make it more plugable #615

Merged

Conversation

fxprunayre
Copy link
Member

@jesseeichar
Copy link

Looks good +1.

@Delawen
Copy link
Contributor

Delawen commented Aug 26, 2014

What about the future improvement on dynamic loading of schemas?

I think this is important, specially if we want to simplify the process and allow users to add and update schemas using a UI. With this change we will not only have to restart the server, but also modify the original war/folder on tomcat when we add or update a schema.

I am not saying we shouldn't merge this, I think it is great improvement and very helpful.I am just a bit worried on this point. Loading java classes outside the default classpath is a bit complicated. I tried to do that on a previous project a few years ago and it was feasible but a bit nightmare... not sure if I just didn't know how to do it properly.

@fxprunayre
Copy link
Member Author

What about the future improvement on dynamic loading of schemas?

I may be wrong, but I don't see many users adding dynamically new schemas using the web interface. Most of the time, we build custom GeoNetwork with some custom schemas and users are installing those applications (like Anzmest, GéoSource, Geonovum, CDI, Sextant, ...). Having a good documentation explaining how to add a schema and even if it requires a restart of the application sounds enough for me.

With this change we will not only have to restart the server, but also modify the original war/folder on tomcat when we add or update a schema.

Only if the plugin add a custom bean which is optional and should not happen for all existing ISO19139 profiles.

@Delawen
Copy link
Contributor

Delawen commented Aug 26, 2014

You convinced me 👍

François Prunayre added 2 commits August 29, 2014 15:45
…/schema-plugin-bean

Conflicts:
	domain/pom.xml
	pom.xml
	web-ui/src/main/resources/catalog/locales/en-editor.json
	web-ui/src/main/resources/catalog/locales/fr-editor.json
	web/src/main/webapp/WEB-INF/data/config/schema_plugins/config-editor.xsd
@fxprunayre fxprunayre added this to the 2.11.0 milestone Aug 29, 2014
@fxprunayre fxprunayre self-assigned this Sep 4, 2014
fxprunayre pushed a commit that referenced this pull request Sep 4, 2014
Schema plugin / Add schema bean to make it more plugable
@fxprunayre fxprunayre merged commit 2292ac8 into geonetwork:develop Sep 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants